Fixing miscellaneous checkstyle errors #3169
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @since 1.0.0 | ||
| */ | ||
| public class VectorStoreChatMemoryAdvisor implements BaseChatMemoryAdvisor { | ||
| public final class VectorStoreChatMemoryAdvisor implements BaseChatMemoryAdvisor { |
Member
There was a problem hiding this comment.
Is this by design that we don't want to allow any customization?
sobychacko
force-pushed
the
checkstyle-fix-rc1
branch
2 times, most recently
from
5bcd745 to
d6a4c76
Compare
Enabling checkstyle by default in the project build Signed-off-by: Soby Chacko <[email protected]>
sobychacko
force-pushed
the
checkstyle-fix-rc1
branch
from
d6a4c76 to
26634bb
Compare
Member
|
Rebased and merged as 368be3a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.